Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

versionCode is not being incremented #4

Open
NathHorrigan opened this issue Sep 9, 2018 · 2 comments
Open

versionCode is not being incremented #4

NathHorrigan opened this issue Sep 9, 2018 · 2 comments

Comments

@NathHorrigan
Copy link

Hi!

Great package but it doesn't seem to be incremented the apps version code in the android build.grade. Is this possible to fix??
@Cnordbo
Copy link

Cnordbo commented Nov 16, 2018

Should be, and works fine here - any more details about your issue?
https://github.com/gustarus/react-native-version-up/blob/master/index.js#L15-L16

@nickelbob
Copy link

nickelbob commented Oct 12, 2019 •
edited
Loading

This broke for me and the reason is that my CFBundleVersion in my Info.plist looks like this -

<key>CFBundleVersion</key>
<string>$(CURRENT_PROJECT_VERSION)</string>

I'm not sure what changed this from a int to an env var but it might be the cause of other people's issues.

Here's a PR for the changes needed to get the version code from the build.gradle instead of the Info.plist - #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Cnordbo @nickelbob @NathHorrigan