Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test #49

Open
NorikDavtian opened this issue Mar 13, 2018 · 4 comments
Open

Failing test #49

NorikDavtian opened this issue Mar 13, 2018 · 4 comments

Comments

@NorikDavtian
Copy link

  ․․․․․․․․․․!․․

  12 passing (504ms)
  1 failing

  1) Gun using level should merge with existing data:
     Uncaught Error: Expected { _: { '#': 'gkww0wuvad6', '>': { success: 1520904130506 } }, success: true } to include { success: true, data: true }
      at assert (node_modules/expect/lib/assert.js:29:9)

on src/spec.js:87
changing the makeGun() to the glogbal gun variable fixes the issue, but not sure if that's the right behavior or not? or this is an async issue?!

@amark
Copy link
Collaborator

amark commented Mar 15, 2018

@NorikDavtian welcome!!! :)

That particular test we found out is actually non-deterministic (if you re-run a couple times it will occasionally pass). I didn't write the code, so I would need to sit down and go through it.

My plan is to probably deprecate the existing code, swap in the Radix Storage Engine (which is what S3 and other adapters use) instead, and then use Level on that. However this is pretty low priority.

I noticed you are at dollarshaveclub though - would love to hear about any potential use case for gun there? If it requires Level, maybe I could bump the priority up!

@NorikDavtian
Copy link
Author

NorikDavtian commented Mar 16, 2018

Thanks @amark , that was my understanding of what was happening there. Currently just exploring different data transfer, transform, and storage strategies. Just stumbled on this and wanted to give it a try. We have a wide variety of use cases that we look for creative ways to solve. Good to have options :)

@amark
Copy link
Collaborator

amark commented Mar 22, 2018

@NorikDavtian what would be needed to do a PoC for you guys? :)

@NorikDavtian
Copy link
Author

@amark I will dm you on gitter if anything notable comes along to collaborate on a PoC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants