Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The documentation for standalone usage uses a Laravel specific Session implementation #1

Open
HelgeSverre opened this issue Apr 8, 2019 · 0 comments
Open

The documentation for standalone usage uses a Laravel specific Session implementation #1

HelgeSverre opened this issue Apr 8, 2019 · 0 comments
Assignees
@HelgeSverre
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@HelgeSverre
Copy link
Contributor

Should be changed to either use the ValueStore class directly (not via Laravel facade) or use another session implementation, so people don't copy paste the example and have it not work due to using Laravel magic.
@HelgeSverre HelgeSverre self-assigned this Apr 8, 2019
@HelgeSverre HelgeSverre added the enhancement New feature or request label Apr 8, 2019
@HelgeSverre HelgeSverre added the good first issue Good for newcomers label May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HelgeSverre HelgeSverre

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HelgeSverre