From ffaf3e8acf40a9354ae352a3f9955622a09ab786 Mon Sep 17 00:00:00 2001 From: HaRuki <62743644+kuri-sun@users.noreply.github.com> Date: Tue, 21 Nov 2023 07:32:53 -0800 Subject: [PATCH] fix(react): warnings from SideNav in console from inert prop (#14990) (#15047) Co-authored-by: Andrea N. Cardona Co-authored-by: TJ Egan --- .all-contributorsrc | 9 +++++++++ README.md | 4 ++++ packages/react/src/components/UIShell/SideNav.tsx | 2 +- 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index 35cfde183594..ca4e29ea2a9c 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -1323,6 +1323,15 @@ "contributions": [ "code" ] + }, + { + "login": "kuri-sun", + "name": "Ruki", + "avatar_url": "https://avatars.githubusercontent.com/u/62743644?v=4", + "profile": "https://haruki-kuriwada.netlify.app/", + "contributions": [ + "code" + ] } ], "commitConvention": "none" diff --git a/README.md b/README.md index f91e7a582750..63c8120a37fd 100644 --- a/README.md +++ b/README.md @@ -258,9 +258,13 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
Aman Lajpal

💻 📖 +
Niraj Sah

💻
Allison Ishida

💻
Alex Lewitt

💻 +
Ruki

💻 +
Allison Ishida

💻
Tresau-IBM

💻 +
Alex Lewitt

💻 diff --git a/packages/react/src/components/UIShell/SideNav.tsx b/packages/react/src/components/UIShell/SideNav.tsx index 99a1887b0ad3..517147edf320 100644 --- a/packages/react/src/components/UIShell/SideNav.tsx +++ b/packages/react/src/components/UIShell/SideNav.tsx @@ -239,7 +239,7 @@ function SideNavRenderFunction( tabIndex={-1} ref={navRef} className={`${prefix}--side-nav__navigation ${className}`} - inert={!isRail && (expanded || isLg ? undefined : -1)} + inert={!isRail ? (expanded || isLg ? undefined : -1) : undefined} {...accessibilityLabel} {...eventHandlers} {...other}>