Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used package is not listed as a dependency #8

Open
mzyil opened this issue Feb 26, 2019 · 1 comment · May be fixed by #9
Open

Used package is not listed as a dependency #8

mzyil opened this issue Feb 26, 2019 · 1 comment · May be fixed by #9

Comments

@mzyil
Copy link

mzyil commented Feb 26, 2019

Hi, this package depends on async v1.5.x (so does botbuilder v3). However that async package is not listed in the dependencies and it causes problems with the other package which depend on different versions of the async package. npm installs them to the related package's own folder, forcing this package to use the old version.

I will open a PR related to this and add the async version that the required botbuilder version requires.

People with the wrong version would get:

... async.forEachOfSeries is not a function
    at TestConnector.send (... /node_modules/botbuilder-unit/src/TestConnector.js:36:11)

TestConnector.js requires async.

@mzyil mzyil linked a pull request Feb 26, 2019 that will close this issue
@mzyil
Copy link
Author

mzyil commented Apr 3, 2019

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant