Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fix #14

Merged
merged 2 commits into from
Dec 25, 2023
+6 −8
Merged

build fix #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2021eba
build fix
gtiwari333 Dec 25, 2023
14ed12b
trying with headless
gtiwari333 Dec 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

steps:
- uses: actions/checkout@v2
- uses: browser-actions/setup-chrome@v1
- uses: browser-actions/setup-edge@v1

- name: Set up JDK 21
uses: actions/setup-java@v1
Expand Down
4 changes: 2 additions & 2 deletions main-app/main-webapp/src/test/java/gt/app/frwk/BaseSeleniumTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ public abstract class BaseSeleniumTest {

@BeforeAll
public static void init() {
Configuration.headless = false;
Configuration.browser = Browsers.CHROME;
Configuration.headless = true;
Configuration.browser = Browsers.EDGE;
}

@BeforeEach
Expand Down
2 changes: 1 addition & 1 deletion main-app/main-webapp/src/test/java/gt/app/frwk/SampleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class SampleTest {
static void setup() {
Configuration.baseUrl = "https://en.wikipedia.org/wiki/Main_Page";
Configuration.headless = true;
Configuration.browser = Browsers.CHROME;
Configuration.browser = Browsers.EDGE;
}

@Test
Expand Down
6 changes: 2 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,9 @@
<springdoc-openapi-ui.version>2.3.0</springdoc-openapi-ui.version>
<mapstruct.version>1.6.0.Beta1</mapstruct.version>

<selenide.version>7.0.1</selenide.version>
<!-- selenide generally uses new selenium. Spring Boot Dep Mgmt still provides older version -->
<selenium.version>4.13.0</selenium.version>
<selenide.version>7.0.4</selenide.version>

<google-guava.version>32.1.3-jre</google-guava.version>
<google-guava.version>33.0.0-jre</google-guava.version>
<wro4j.version>1.9.0</wro4j.version>
<archunit.version>1.2.1</archunit.version>
<testcontainers.version>1.19.3</testcontainers.version>
Expand Down
Loading