Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Preview a previous version" anti-feature? #695

Open
j-ulrich opened this issue Dec 11, 2023 · 0 comments
Open

"Preview a previous version" anti-feature? #695

j-ulrich opened this issue Dec 11, 2023 · 0 comments

Comments

@j-ulrich
Copy link

I think this "preview a previous version" (#187) is an anti-feature because:

  • The [//]: # s-${version} and [//]: # e-${version} metadata clutters the resulting output.
  • It limits the plugin to markdown. Before, I think it was possible to generate other formats simply by using a different template.
  • This functionality seems to be misplaced in the plugin because the plugin is about generating a change log and not about parsing resp. extracting something from it. This sounds like a responsibility for a change log parser.

I guess the first two points could be fixed by making the metadata configurable.

What do you think about these points?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant