Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image aligning still not working properly #58

Open
xtrojak opened this issue Nov 23, 2023 · 2 comments · Fixed by #60
Open

Image aligning still not working properly #58

xtrojak opened this issue Nov 23, 2023 · 2 comments · Fixed by #60
Labels

Comments

@xtrojak
Copy link
Collaborator

xtrojak commented Nov 23, 2023

There are still cases when forms aligning is not working. Sometimes not the most outer corners are considered. Perhaps we need to make our own implementation, without relying on external libraries. This way we can also try to solve #38.

@xtrojak
Copy link
Collaborator Author

xtrojak commented Dec 5, 2023

There are still cases when some of the outer border corners are not detected at all.

@xtrojak xtrojak reopened this Dec 5, 2023
@xtrojak
Copy link
Collaborator Author

xtrojak commented Feb 26, 2024

Currently, the alignment works in ~99% cases. For future development to push this to perfection, we can consider:

  • first run OCR annotation and do alignment based on some artefacts (basically Fiducial marker)
    • these are possibly not always detected, but if we use enough of them, it should be okay
    • then alignment is done separately for every service
  • another option (easier) - work with distance between detected points
    • if they are different, try to change the sensitivity parameters of employed alignment library
  • possibley enforce proper Fiducial marker in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant