-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement clean parser #7
Comments
cc @abloom @mcculloughsean - on a scale of 1-10: How stupid is this idea? |
For what benefit? Why would we want to strip it? |
Pretty much 100% of that is not used by us. But somebody who wants to parse CSON files will have to download all of it. And there's the point that CSR is in eternal beta and seems all but abandoned. |
I mean, it sounds like a fine idea, but it sounds like a bunch of work that's only benefit is to make the download smaller? Is there a performance improvement? |
I wouldn't expect a serious performance improvement (it's not doing that much more). But it would cut the installed size of this package in half and help defining what exactly valid CSON is (without referring to CSR implementation details). I'm not sure the initial implementation is really worth it, but it might be a fun weekend project at some point. |
It would be pretty neat if it didn't choke on legal coffee-script literals that cs-redux hates on, such as { "comma": "first"
, "basic": "json"
} |
@johan Since you know my hate for comma-first I'm sure you know that this is unlikely to make the cut if I'd be writing the parser... ;) |
I thought it was Sean McCullough who was the comma-first hater. :-) |
👍 to a clean implementation without a CSR dependency |
Right now we are using CSR for parsing which handles a huge superset of the files we'd want to parse. We should consider implementing a clean parser for CSON as part of this repo.
The text was updated successfully, but these errors were encountered: