Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement clean parser #7

Open
jkrems opened this issue Oct 6, 2014 · 9 comments
Open

Implement clean parser #7

jkrems opened this issue Oct 6, 2014 · 9 comments

Comments

@jkrems
Copy link
Contributor

jkrems commented Oct 6, 2014

Right now we are using CSR for parsing which handles a huge superset of the files we'd want to parse. We should consider implementing a clean parser for CSON as part of this repo.

@jkrems
Copy link
Contributor Author

jkrems commented Oct 6, 2014

cc @abloom @mcculloughsean - on a scale of 1-10: How stupid is this idea?

@abloom
Copy link
Contributor

abloom commented Oct 6, 2014

For what benefit? Why would we want to strip it?

@jkrems
Copy link
Contributor Author

jkrems commented Oct 6, 2014

├─┬ [email protected]
│ ├── [email protected] (git://github.com/michaelficarra/cscodegen.git#73fd7202ac086c26f18c9d56f025b18b3c6f5383)
│ ├─┬ [email protected]
│ │ ├── [email protected]
│ │ └── [email protected]
│ ├─┬ [email protected]
│ │ ├── [email protected]
│ │ ├── [email protected]
│ │ ├─┬ [email protected]
│ │ │ └── [email protected]
│ │ ├── [email protected]
│ │ └─┬ [email protected]
│ │   ├── [email protected]
│ │   └── [email protected]
│ ├─┬ [email protected]
│ │ └── [email protected]
│ ├─┬ [email protected]
│ │ └── [email protected]
│ └── [email protected]

Pretty much 100% of that is not used by us. But somebody who wants to parse CSON files will have to download all of it. And there's the point that CSR is in eternal beta and seems all but abandoned.

@abloom
Copy link
Contributor

abloom commented Oct 6, 2014

I mean, it sounds like a fine idea, but it sounds like a bunch of work that's only benefit is to make the download smaller? Is there a performance improvement?

@jkrems
Copy link
Contributor Author

jkrems commented Oct 6, 2014

I wouldn't expect a serious performance improvement (it's not doing that much more). But it would cut the installed size of this package in half and help defining what exactly valid CSON is (without referring to CSR implementation details). I'm not sure the initial implementation is really worth it, but it might be a fun weekend project at some point.

@johan
Copy link
Contributor

johan commented Oct 7, 2014

It would be pretty neat if it didn't choke on legal coffee-script literals that cs-redux hates on, such as

{ "comma": "first"
, "basic": "json"
}

@jkrems
Copy link
Contributor Author

jkrems commented Oct 7, 2014

@johan Since you know my hate for comma-first I'm sure you know that this is unlikely to make the cut if I'd be writing the parser... ;)

@johan
Copy link
Contributor

johan commented Oct 7, 2014

I thought it was Sean McCullough who was the comma-first hater. :-)

@mcculloughsean
Copy link

👍 to a clean implementation without a CSR dependency

@jkrems jkrems marked this as a duplicate of #66 Jul 20, 2017
@jkrems jkrems mentioned this issue Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants