New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up hacky detection of `React.Component` and `React.ReactNode` #4

Open

grncdr opened this issue Nov 27, 2017 · 0 comments

Owner

grncdr commented Nov 27, 2017

Currently the code just stringifies types and compares them against constant strings. This doesn't work if the import isn't named React.

Investigation needed: can we do reliable symbol comparisons with ts.Symbol.equals?

Tests should cover:

import {Component, ReactNode} from 'react' && class Foo extends Component<{n: ReactNode}> {}
import * as R from 'react': class Foo extends R.Component<{n: R.ReactNode}>

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment