Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter Bootstrap 2 #34

Open
jamesward opened this issue Jan 30, 2012 · 14 comments
Open

Twitter Bootstrap 2 #34

jamesward opened this issue Jan 30, 2012 · 14 comments

Comments

@jamesward
Copy link

I'm trying to get Twitter Bootstrap 2 working with GreenScript and getting Less compile errors like:

error compile less file: /public/stylesheets/bootstrap.less, error: Parse Error: Syntax Error on line 15 (line 15, column 210)

I'm just doing:

#{greenscript.css "bootstrap.less", output:'all' /}

Strange thing is that there isn't a column 210 on line 15 of the bootstrap.less file.

@greenlaw110
Copy link
Owner

please report your play version and greenscript version. thx

On Tue, Jan 31, 2012 at 10:59 AM, James Ward <
[email protected]

wrote:

I'm trying to get Twitter Bootstrap working with GreenScript and getting
Less compile errors like:

error compile less file: /public/stylesheets/bootstrap.less, error:
Parse Error: Syntax Error on line 15 (line 15, column 210)

I'm just doing:

#{greenscript.css "bootstrap.less", output:'all' /}

Strange thing was there there wasn't a column 210 on line 15 of the
bootstrap.less file.


Reply to this email directly or view it on GitHub:
#34

@jamesward
Copy link
Author

play-1.2.4
greenscript-1.2.6m

Thanks for the quick response.

@greenlaw110
Copy link
Owner

I cannot reproduce this issue. Here is a simple app I've created and it
works fine: http://ge.tt/90zM8yC?c

On Tue, Jan 31, 2012 at 11:18 AM, James Ward <
[email protected]

wrote:

play-1.2.4
greenscript-1.2.6m

Thanks for the quick response.


Reply to this email directly or view it on GitHub:
#34 (comment)

@jamesward
Copy link
Author

That looks like Bootstrap 1 not 2. I'll try to put together a little example.

@jamesward
Copy link
Author

Here is a little sample app with the Bootstrap 2 less files:
https://github.com/jamesward/bootstrap2test

@greenlaw110
Copy link
Owner

This one should be fixed in the 1.2.7, could you please give it a try?

@lrobinot
Copy link

The problem have been fixed (from my point of view), at least for the version 2.0.0 of Bootstrap. But the version 2.0.2 (released these days) need the 1.3 version of the less compiler, as stated here : http://www.markdotto.com/2012/03/12/bootstrap-2-0-2-released/

@greenlaw110
Copy link
Owner

We will need to wait for lesscss-engine updates if v1.1.5 is not using less
1.3

On Thu, Mar 15, 2012 at 12:15 AM, Ludovic ROBINOT <
[email protected]

wrote:

The problem have been fixed (from my point of view), at least for the
version 2.0.0 of Bootstrap. But the version 2.0.2 (released these days)
need the 1.3 version of the less compiler, as stated here :
http://www.markdotto.com/2012/03/12/bootstrap-2-0-2-released/


Reply to this email directly or view it on GitHub:
#34 (comment)

@mikenikles
Copy link

Just curious, is there an update to this issue? I use Play 1.2.4 with Greenscript 1.2.8b and Bootstrap 2.0.4 and get the following error:

error compile less file: /public/stylesheets/bootstrap/less/bootstrap.less, error: Parse Error: Syntax Error on line 550 (line 550, column 17902)

Thanks,

Mike

@jonathonadler
Copy link

Replacing lesscss-engine-1.1.5.jar with lesscss-engine-1.3.0.jar in %PLAY_HOME%\modules\greenscript-1.2.8b\lib seems to fix the issue for me.

@mikenikles
Copy link

That's ok for a workaround until Greenscript updates the dependency. Thanks

@jtammen
Copy link

jtammen commented Oct 23, 2012

Hi,

any update on integrating version 1.3.0 of lesscss-engine? A new release of greenscript would be really appreciated!

I am using the ZURB Foundation framework and had a similar problem caused by this CSS rule:

@-moz-document url-prefix("http://") {
  // ...
}

At least that one was fixed by temporarily replacing lesscss-engine-1.1.5.jar by lesscss-engine-1.3.0.jar. Now it still complains about that CSS rule (resp the "filter" line):

div.caption { 
  background:transparent;
  filter:progid:DXImageTransform.Microsoft.gradient(startColorstr=#99000000,endColorstr=#99000000);
  zoom: 1;
}

I also tried to escape that rule, but that did not change anything. However, I can circumvent that problem by commenting out that rule, as I currently don't need it. Should this be reported to the lesscss-engine maintainer?

Greets,
Jan.

@greenlaw110
Copy link
Owner

Yes I think you need to report that issue to lesscss-engine maintainer. And
yes I will try to release an new version with 1.3.0 less engine integrated.
thanks a lot for reporting this

On Wed, Oct 24, 2012 at 12:01 AM, Jan Tammen [email protected]:

Hi,

any update on integrating version 1.3.0 of lesscss-enginehttp://asual/lesscss-engine?
A new release of greenscript would be really appreciated!

I am using the ZURB Foundation framework and had a similar problem caused
by this CSS rule:

@-moz-document url-prefix("http://") {
// ...}

At least that one was fixed by temporarily replacing
lesscss-engine-1.1.5.jar by lesscss-engine-1.3.0.jar. Now it still
complains about that CSS rule (resp the "filter" line):

div.caption {
background:transparent;
filter:progid:DXImageTransform.Microsoft.gradient(startColorstr=#99000000,endColorstr=#99000000);
zoom: 1;}

I also tried to escape that rule http://lesscss.org/#-escaping, but
that did not change anything. However, I can circumvent that problem by
commenting out that rule, as I currently don't need it. Should this be
reported to the lesscss-engine maintainer?

Greets,
Jan.


Reply to this email directly or view it on GitHubhttps://github.com//issues/34#issuecomment-9700720.

@jtammen
Copy link

jtammen commented Oct 25, 2012

Cool!

Just for the record: found out that actually escaping the rule correctly did solve the problem. Using this works:

filter:progid:DXImageTransform.Microsoft.gradient(startColorstr=~\"#99000000\",endColorstr=~\"#99000000\"); 

Greets,
Jan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants