Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser option not working #31

Open
ghost opened this issue Jan 12, 2012 · 1 comment
Open

Browser option not working #31

ghost opened this issue Jan 12, 2012 · 1 comment

Comments

@ghost
Copy link

ghost commented Jan 12, 2012

I'm using greenscript 1.2.6m. Loving it so far. Ran into a small problem. The browser option doesn't do anything. If my webpage has
#{greenscript.css "base", output:true/}
#{greenscript.css 'base-ie8', browser: 'IE 8', output:true/}
the output is just two lines without the conditional comments.

I noticed a missing underscore in your gs_.html file on line 36. It says browser: browser, but I think it should be browser: _browser. Also, should the media attribute also have an underscore? Not sure, because I haven't tested it.

@jtammen
Copy link

jtammen commented Feb 11, 2012

Hey,

maybe you can try something like this:

#{greenscript.css 'base' /}
#{greenscript.css 'base-ie8', browser: 'IE 8', media: 'screen' /}
#{greenscript.css output: 'all'}

I needed the media attribute as well as the third greenscript tag in order to get the desired result ... don't know whether this is the way it was intended to work.

I am using Play 1.2.4 and GreenScript version 1.2.7 and no greenscript.conf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant