-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable AppVeyor artifact comments in pull requests #119
Comments
Hi @agitter , sorry for my slow response on this issue. For this project especially, I think user-friendliness is a priority, even if it generates more notifications. If this is something you are able to implement, I think it would be helpful for this project and potentially might serve to pique more people's interest in manubot. |
The
|
I think I have done this. We can check the status of this when it finishes: https://ci.appveyor.com/project/cgreene/covid19-review/builds/31903395 |
Is your feature request related to a problem? Please describe.
Viewing manuscript artifacts through GitHub Actions is somewhat cumbersome.
Describe the solution you'd like
AppVeyor can comment on a pull request after the manuscript builds, directly linking to the HTML and PDF artifacts. See greenelab/deep-review#997 (comment) for an example.
Describe alternatives you've considered
I attempted to implement a similar feature with GitHub Actions comments upstream in rootstock. It isn't currently possible for reasons detailed in manubot/rootstock#327
Additional context
The project leads would need to evaluate the tradeoffs of having manuscript artifacts more easily accessible during review versus the additional notifications generated. AppVeyor's pull request comments trigger a notification every time the artifact is posted. I don't mind that, but some people do.
The text was updated successfully, but these errors were encountered: