Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Puts 1.0 examples for how to customize Expectations under test. #10235

Merged

Conversation

Rachel-Reverie
Copy link
Contributor

Description

  • Puts 1.0 examples into scripts under test for:
    • How to customize an Expectation class
    • How to implement row conditions for an Expectation
    • How to use SQL to customize an UnexpectedRowsExpectation

Definition of done:

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit ab531eb
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/66c4cb33e993240008d0a139
😎 Deploy Preview https://deploy-preview-10235.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.67%. Comparing base (23b5257) to head (ab531eb).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10235   +/-   ##
========================================
  Coverage    79.67%   79.67%           
========================================
  Files          454      454           
  Lines        39541    39541           
========================================
  Hits         31503    31503           
  Misses        8038     8038           
Flag Coverage Δ
3.10 66.31% <ø> (ø)
3.11 66.30% <ø> (ø)
3.12 64.85% <ø> (ø)
3.12 aws_deps 45.80% <ø> (ø)
3.12 big 54.46% <ø> (ø)
3.12 filesystem 60.45% <ø> (ø)
3.12 mssql 49.90% <ø> (ø)
3.12 mysql 49.96% <ø> (ø)
3.12 postgresql 54.10% <ø> (ø)
3.12 spark 57.56% <ø> (ø)
3.12 trino 52.17% <ø> (ø)
3.8 66.34% <ø> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.65% <ø> (ø)
3.8 aws_deps 45.83% <ø> (ø)
3.8 big 54.48% <ø> (ø)
3.8 databricks 47.09% <ø> (ø)
3.8 filesystem 60.47% <ø> (ø)
3.8 mssql 49.89% <ø> (ø)
3.8 mysql 49.95% <ø> (ø)
3.8 postgresql 54.09% <ø> (ø)
3.8 snowflake 48.01% <ø> (ø)
3.8 spark 57.53% <ø> (ø)
3.8 trino 52.16% <ø> (ø)
3.9 66.32% <ø> (-0.02%) ⬇️
cloud 0.00% <ø> (ø)
docs-basic 50.21% <ø> (+<0.01%) ⬆️
docs-creds-needed 51.20% <ø> (+0.04%) ⬆️
docs-spark 50.18% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…xpectations

# Conflicts:
#	docs/docusaurus/docs/components/examples_under_test.py
Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 3 small comments and a typo.

@Rachel-Reverie Rachel-Reverie added this pull request to the merge queue Aug 20, 2024
Merged via the queue into develop with commit 2fd5143 Aug 20, 2024
62 checks passed
@Rachel-Reverie Rachel-Reverie deleted the d/doc-807/1-0_code_under_test_customize_expectations branch August 20, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants