Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject WriterInterface and use it for testing #15

Open
h-bragg opened this issue May 11, 2017 · 0 comments
Open

Inject WriterInterface and use it for testing #15

h-bragg opened this issue May 11, 2017 · 0 comments

Comments

@h-bragg
Copy link
Collaborator

h-bragg commented May 11, 2017

Recent changes mean we can remove 'testing' only methods on the Client class.

  • Inject a WriterInterface and use that (could be tricky from a simple usage scenario)
  • Remove getLastMessage and wasSuccessful methods
  • Update all tests to use a Mocked WriterInterface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@h-bragg