Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rendering for amenity=car_rental #857

Closed
moliha opened this issue Aug 6, 2014 · 4 comments · Fixed by #1388
Closed

Add rendering for amenity=car_rental #857

moliha opened this issue Aug 6, 2014 · 4 comments · Fixed by #1388
Labels
amenity-points
Milestone
New features

Comments

@moliha
Copy link

moliha commented Aug 6, 2014

amenity = bicycle_rental is rendered ok
but -
amenity = car_rental is completely invisible - no icon - no name - nothing at any zoom level.

In my opinion, this is too bad to be left uncorrected for long...
@matthijsmelissen
Copy link
Collaborator

See also #108.

@matthijsmelissen matthijsmelissen changed the title amenity = car_rental is not rendered Add rendering for amenity=car_rental Aug 6, 2014
@pnorman pnorman added this to the New features milestone Aug 8, 2014
@matkoniecz
Copy link
Contributor

http://taginfo.openstreetmap.org/tags/amenity=car_rental - over 6k times, there is a wiki page

I think that it is a good addition, but somebody needs to make an icon.

@matthijsmelissen
Copy link
Collaborator

The icon exists already: http://www.sjjb.co.uk/mapicons/contactsheet

@nebulon42 nebulon42 mentioned this issue Feb 1, 2015
Closed
@nebulon42
Copy link
Contributor

New icon available: https://github.com/nebulon42/osmic/blob/master/transport/rental-car-16.svg
For a PR I would need to know how the label should be rendered (name/operator/brand).

nebulon42 added a commit to nebulon42/openstreetmap-carto that referenced this issue Mar 15, 2015
@nebulon42
add rendering for amenity=car_rental (resolves gravitystorm#857)
a3dec10
nebulon42 added a commit to nebulon42/openstreetmap-carto that referenced this issue Mar 15, 2015
@nebulon42
add rendering for amenity=car_rental (resolves gravitystorm#857)
47e256d
@nebulon42 nebulon42 mentioned this issue Mar 15, 2015
Merged
sommerluk pushed a commit to sommerluk/openstreetmap-carto that referenced this issue Mar 16, 2015
@nebulon42 @sommerluk
add rendering for amenity=car_rental (resolves gravitystorm#857)
6af94a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
amenity-points
Projects
None yet
Milestone
New features
Development

Successfully merging a pull request may close this issue.

add rendering for amenity=car_rental nebulon42/openstreetmap-carto
5 participants
@matkoniecz @pnorman @nebulon42 @matthijsmelissen @moliha