Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render man_made=watermill #3692

Closed
fiuncho opened this issue Feb 23, 2019 · 7 comments
Closed

render man_made=watermill #3692

fiuncho opened this issue Feb 23, 2019 · 7 comments
Labels
declined new features Requests to render new features POI
Milestone

Comments

@fiuncho
Copy link

fiuncho commented Feb 23, 2019

I have been mapping some watermills and I realized it doesn't render in carto. However I've found that carto renders windmills and windmills numbers are not much higher, according to taginfo.

In what follows I post some examples:

Watermills:
https://www.openstreetmap.org/node/5338734755
https://www.openstreetmap.org/way/672532693

Windmills:
https://www.openstreetmap.org/node/527858702#map=19/51.48548/4.46008
https://www.openstreetmap.org/way/146213769

@kocio-pl kocio-pl added the new features Requests to render new features label Feb 23, 2019
@kocio-pl kocio-pl added this to the New features milestone Feb 23, 2019
@kocio-pl
Copy link
Collaborator

Looks sane for me, but we need an icon for that.

https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dwatermill

taghistory 48

@wilmaed
Copy link

wilmaed commented Feb 24, 2019

we need an icon for that.

like that?

https://github.com/wilmaed/foo/blob/master/watermill14.svg

mill14

@Adamant36
Copy link
Contributor

Looks like a gear getting oil on it or something.

Here's a link to Noun Project with a few icons that might be worth trying

https://thenounproject.com/search/?q=watermill

@wilmaed
Copy link

wilmaed commented Feb 24, 2019

https://github.com/wilmaed/foo/blob/master/mill4.svg
mill14_

https://github.com/wilmaed/foo/blob/master/mill5.svg
mill14__

@wilmaed
Copy link

wilmaed commented Feb 24, 2019

Clipped and resized ID-Editor Icon:
https://github.com/wilmaed/foo/blob/master/mill6.svg

watermill-15

@imagico
Copy link
Collaborator

imagico commented May 23, 2022

I suggest to close this as declined - the tag is apparently equally used for

  • former watermill buildings without any actual watermill structure being still present
  • disused watermills with preserved structure
  • operational watermills

with no established tagging to differentiate between those. That makes any rendering kind of problematic i think.

I would rather like to see power=generator + generator:source=hydro being rendered.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jun 8, 2022

Closing as declined due to reasons in the above comment: this tag is used for historic, disused watermills, history watermill buildings which are now re-purposed for some other use, as well as a few operational watermills. This makes it difficult to provide a rendering which matches the use of the tag. Note that closing this issue was also recommended in #4555 (comment)

@jeisenbe jeisenbe closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined new features Requests to render new features POI
Projects
None yet
Development

No branches or pull requests

6 participants