-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please do not put highway numbers exactly on overpasses or junctions #3219
Comments
As far as I know, this is technically not possible with our current rendering software stack. |
Furthermore I have no problem sorting the things out, because shield colors are different. |
What if one day, the shield colors are the same? I don't know of any other paper, or on-line map that ever has done this. Nor any cartographer. I don't think that closing the bug will help get this solved. |
The best thing to help is to write the code that could solve it while not introducing some other problems. If you know how to do it, just please try, because we don't. "What if" is not the problem to solve. If someone will make the shield colors uniform, she will have to deal with this issue - but only then. |
Well please don't throw the bug away because there is no instant solution. |
I don't think that leaving bug open will help anything too. Bug tracker is just a tool to manage problems, open status is not a magic wand. There are no guarantees to solve anything "eventually", there are rather big chances that it will just clutter the space. I am digging in the old tickets from time to time, so having such issues open really makes it harder to discover problems that can be solved. |
Also even if the only problem is shield colors, one day Provincial Highway 7 will cross Provincial Highway 8. If you can manage not putting a 7 or an 8 smack in the middle of a flat intersection, then the same should be possible in three dimensions. Or just as a rule don't put them smack in the middle of any bridge. |
Still we see no solution and adding "what ifs" is not helping anything. Do you have any code to solve it or even a hint how to code it? |
Basic solution:
while(haven't reached end of road yet){
x+=500 meters;
if(on a bridge){do nothing}else{place marker}.
}
Or use
if(on a short bridge){...}
|
We use SQL + CartoCSS here. You need to think in terms of selecting database values that mean "short bridge" for a start. Next thing is to look how the shields are placed in https://github.com/gravitystorm/openstreetmap-carto/blob/master/roads.mss. |
SELECT bridge WHERE (SELECT bridge.length > 100 meters) etc.
Also all this thinking needs to be done in meters before you hit the
roads.mss style files.
|
In case of this style, especially roads, you have to debug, not simply write code:
It's not given that you will succeed, but this is a way to go. |
sent from a phone
On 7. May 2018, at 14:41, kocio-pl ***@***.***> wrote:
Still we see no solution and adding "what ifs" is not helping anything.
first render invisible shields on intersections, then render the actual shields.
|
I was thinking, I have never seen a marker rendered underneath a bridge or even partly underneath a bridge. Therefore perhaps add a pseudo bridge on top of a bridge then run the marker rendering algorithm and then remove the pseudo bridge. I will look at those files later. |
Great. If you want to understand overall design of this style and test it a bit, it's good to start with these links: |
I am sorry. I must maintain my role as just the bug reporter. All I can respectfully leave you with is a link, |
Unfortunately I also expect that given technical limitations of this style it is unfixable. It would be great to see a PR fixing this (assuming that it is not introducing other worse cartographic or significant performance issues). But unfortunately I would not expect this to be possible in general. One thing that may help is #951 that would solve also other shield-related issues. Stopgap solutions like not rendering shields on bridge ways may or may not help but I am not convinced that it is a good way to solve that. |
Here https://www.openstreetmap.org/#map=15/41.7697/-86.7312 Anyway if one is going to place a number in an ambiguous place, make |
Why does the program often insist on putting highway numbers exactly on top of
overpasses?
Please have it notice that this is an overpass, and put it very clearly to
the right or left etc.
All it is doing is increasing the confusion as to which road is which.
Sure, we should know that the road on top is the road it is talking
about. But OK we are not that smart. So please still move them to the
side. Yes we should zoom in and out to get a different view. Problem
solved. But then again we are not that smart.
https://www.openstreetmap.org/#map=15/24.8489/121.2010
The text was updated successfully, but these errors were encountered: