Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special rendering for shop=optician #1408

Closed
kocio-pl opened this issue Mar 18, 2015 · 6 comments
Closed

Add special rendering for shop=optician #1408

kocio-pl opened this issue Mar 18, 2015 · 6 comments

Comments

@kocio-pl
Copy link
Collaborator

We should start rendering shop=optician, probably with this icon from osmfr-cartocss fork:

https://github.com/cquest/osmfr-cartocss/blob/master/symbols/optician.svg

[It was proposed in meta-issue #1402]

@matkoniecz
Copy link
Contributor

shop=optician is already rendered, with generic shop icon (a purple dot). Is it intended as "render shop=optician with a special icon?" For list of rendered tag you may consult https://github.com/matkoniecz/CartoCSSHelper/blob/master/style_specific/default_osm_style.rb or search in code - https://github.com/gravitystorm/openstreetmap-carto/search?utf8=%E2%9C%93&q=optician

@matkoniecz
Copy link
Contributor

The same applies to other clones of this ticket.

@kocio-pl
Copy link
Collaborator Author

I thought that is clearly written in the body of the issue - but of course I can also make title more clear too.

@kocio-pl kocio-pl changed the title Add rendering for shop=optician Add special rendering for shop=optician Mar 18, 2015
@nebulon42
Copy link
Contributor

optician-18.svg: optician-18

@kocio-pl
Copy link
Collaborator Author

Good and recognizable.

nebulon42 added a commit to nebulon42/openstreetmap-carto that referenced this issue Apr 20, 2015
nebulon42 added a commit to nebulon42/openstreetmap-carto that referenced this issue Apr 20, 2015
nebulon42 added a commit to nebulon42/openstreetmap-carto that referenced this issue Apr 20, 2015
@nebulon42
Copy link
Contributor

Apparently closing with the commit in #1493 did not work. Should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants