Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use i18n instance from uikit #1280

Closed
5 of 6 tasks
korvin89 opened this issue Jan 29, 2024 · 3 comments
Closed
5 of 6 tasks

Use i18n instance from uikit #1280

korvin89 opened this issue Jan 29, 2024 · 3 comments
Assignees
@korvin89
Labels
enhancement New feature or request

Comments

@korvin89
Copy link
Contributor

korvin89 commented Jan 29, 2024 •
edited
Loading

We should use one instance of i18n in all packages that completely depend on uikit

Example
@korvin89 korvin89 added enhancement New feature or request help wanted Extra attention is needed labels Jan 29, 2024
@korvin89 korvin89 removed the help wanted Extra attention is needed label May 13, 2024
@amje
Copy link
Contributor

amje commented Jun 8, 2024

@korvin89 Will chartkit be updated?

@korvin89
Copy link
Contributor Author

@korvin89 Will chartkit be updated?

@amje Yep, in the next major

@korvin89 korvin89 self-assigned this Jun 10, 2024
@amje
Copy link
Contributor

amje commented Jun 17, 2024

Closing this. Last issue recreated in chartkit repo: gravity-ui/chartkit#494

@amje amje closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korvin89 korvin89

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amje @korvin89