-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RangeDateSelection): add new component #132
Conversation
Preview is ready. |
eafb388
to
9581842
Compare
3039c97
to
d18afc2
Compare
@@ -0,0 +1,52 @@ | |||
// import {dateTime} from '@gravity-ui/date-utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant comment
export function NowLine() { | ||
const viewport = useViewportDimensions(); | ||
const {start: startDate, end: endDate} = useViewportInterval(); | ||
const [, rerender] = React.useState({}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a pattern for utilities
const {start: startDate, end: endDate} = useViewportInterval(); | ||
const [, rerender] = React.useState({}); | ||
|
||
const nowTime = Date.now(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not dateTime
?
d18afc2
to
061c281
Compare
No description provided.