Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RangeDateSelection): add new component #132

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Conversation

ValeraS
Copy link
Contributor

@ValeraS ValeraS commented Aug 14, 2024

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@ValeraS ValeraS changed the title Feat/range date selection feat(RangeDateSelection): add new component Aug 14, 2024
@ValeraS ValeraS force-pushed the feat/range-date-selection branch 3 times, most recently from eafb388 to 9581842 Compare August 23, 2024 17:44
@ValeraS ValeraS marked this pull request as ready for review September 16, 2024 10:33
@ValeraS ValeraS force-pushed the feat/range-date-selection branch 2 times, most recently from 3039c97 to d18afc2 Compare September 20, 2024 15:12
@@ -0,0 +1,52 @@
// import {dateTime} from '@gravity-ui/date-utils';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant comment

export function NowLine() {
const viewport = useViewportDimensions();
const {start: startDate, end: endDate} = useViewportInterval();
const [, rerender] = React.useState({});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a pattern for utilities

const {start: startDate, end: endDate} = useViewportInterval();
const [, rerender] = React.useState({});

const nowTime = Date.now();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not dateTime?

@ValeraS ValeraS force-pushed the feat/range-date-selection branch from d18afc2 to 061c281 Compare November 8, 2024 15:15
@ValeraS ValeraS merged commit 0f10d44 into main Nov 8, 2024
3 checks passed
@ValeraS ValeraS deleted the feat/range-date-selection branch November 8, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants