Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert lib/srv/db to use slog #50116

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Convert lib/srv/db to use slog #50116

merged 1 commit into from
Dec 16, 2024

Conversation

rosstimothy
Copy link
Contributor

No description provided.

@rosstimothy rosstimothy added the no-changelog Indicates that a PR does not require a changelog entry label Dec 11, 2024
@rosstimothy rosstimothy requested a review from greedy52 December 12, 2024 00:26
@rosstimothy rosstimothy marked this pull request as ready for review December 12, 2024 00:26
@github-actions github-actions bot added database-access Database access related issues and PRs size/sm labels Dec 12, 2024
@github-actions github-actions bot requested a review from hugoShaka December 12, 2024 00:26
greedy52
greedy52 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@greedy52 greedy52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🙏 🙏 🙏 🙏 🙏

lib/srv/db/redis/engine.go Show resolved Hide resolved
@rosstimothy
Copy link
Contributor Author

friendly ping @hugoShaka

@rosstimothy rosstimothy added this pull request to the merge queue Dec 16, 2024
Merged via the queue into master with commit af2db96 Dec 16, 2024
41 checks passed
@rosstimothy rosstimothy deleted the tross/srv_db_slog branch December 16, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greedy52 greedy52 greedy52 approved these changes

@hugoShaka hugoShaka hugoShaka approved these changes

Assignees
No one assigned
Labels
database-access Database access related issues and PRs no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosstimothy @greedy52 @hugoShaka