Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] Logs: Forward the error from the failing case to emitUsageEvent #49237

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

smallinsky
Copy link
Contributor

What

Logging improvement

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-49237.d3pp5qlev8mo18.amplifyapp.com

@smallinsky smallinsky requested a review from r0mant November 19, 2024 21:20
@smallinsky smallinsky added the no-changelog Indicates that a PR does not require a changelog entry label Nov 19, 2024
@smallinsky smallinsky enabled auto-merge November 19, 2024 21:22
@smallinsky smallinsky removed the request for review from r0mant November 19, 2024 21:22
@smallinsky smallinsky added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit 8113875 Nov 19, 2024
40 checks passed
@smallinsky smallinsky deleted the smallinsky/emit_usage_event_forward_error branch November 19, 2024 21:56
@public-teleport-github-review-bot

@smallinsky See the table below for backport results.

Branch Result
branch/v16 Failed
branch/v17 Create PR

@smallinsky smallinsky changed the title Logs: Forward the error from the failing case to emitUsageEvent [v16] Logs: Forward the error from the failing case to emitUsageEvent Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants