Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types for TestAuthServerConfig #49194

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

kiosion
Copy link
Contributor

@kiosion kiosion commented Nov 19, 2024

  • Allow accepting a RealClock instead of only a FakeClock.

Related to #5530.

@kiosion kiosion added the no-changelog Indicates that a PR does not require a changelog entry label Nov 19, 2024
@kiosion kiosion requested review from zmb3 and smallinsky November 19, 2024 15:30
@github-actions github-actions bot requested review from avatus and eriktate November 19, 2024 15:30
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-49194.d3pp5qlev8mo18.amplifyapp.com

@kiosion kiosion force-pushed the maxim/fix-flakey-test-cleanup branch 2 times, most recently from 8196335 to 0c4ea0d Compare November 19, 2024 22:03
lib/auth/tls_test.go Outdated Show resolved Hide resolved
@hugoShaka hugoShaka self-requested a review November 19, 2024 22:31
* Allow accepting a RealClock instead of only a FakeClock.
@kiosion kiosion force-pushed the maxim/fix-flakey-test-cleanup branch from 0c4ea0d to a5e96c2 Compare November 19, 2024 22:41
@kiosion kiosion requested a review from smallinsky November 19, 2024 22:42
@kiosion kiosion added this pull request to the merge queue Nov 22, 2024
Merged via the queue into master with commit bf933b5 Nov 22, 2024
40 checks passed
@kiosion kiosion deleted the maxim/fix-flakey-test-cleanup branch November 22, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants