[web] Tidy reused Menu components #48904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiosion
added
the
no-changelog
kiosion
force-pushed
the
maxim/tidy-menus
branch
4 times, most recently
from
48a53f3 to
491b36d
Compare
ravicious
reviewed
Nov 14, 2024
kiosion
force-pushed
the
maxim/tidy-menus
branch
from
06c37c7 to
34ce3fc
Compare
ravicious
approved these changes
Nov 18, 2024
| @@ -164,8 +164,7 @@ export const MultiselectMenu = <T extends string>({ | |||
| <> | |||
| <CheckboxInput | |||
| type="checkbox" | |||
| // @ts-expect-error assigning ReactNode to checkbox name field | |||
| name={opt.label} | |||
| name={opt.value} | |||
There was a problem hiding this comment.
Oh yeah, opt.value is much better and actually aligns with what this attribute is for – it completely escaped my head when I was writing the original comment.
web/packages/shared/components/Controls/MultiselectMenu.story.tsx
Outdated
Show resolved
Hide resolved
web/packages/shared/components/Controls/ViewModeSwitch.story.tsx
Outdated
Show resolved
Hide resolved
kiosion
force-pushed
the
maxim/tidy-menus
branch
2 times, most recently
from
da953ff to
c34f66d
Compare
* Add generic MultiselectMenu, ViewModeSwitch, SortMenu components
kiosion
force-pushed
the
maxim/tidy-menus
branch
from
c34f66d to
576175b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generic MultiselectMenu, ViewModeSwitch, and SortMenu components, replace usages in UnifiedResources.
Resolves #5457.