From 33093d6b013e8044359251b9ea5b301b130cf0d2 Mon Sep 17 00:00:00 2001
From: Tim Ross <tim.ross@goteleport.com>
Date: Fri, 8 Nov 2024 12:28:55 -0500
Subject: [PATCH] Remove deprecated slack plugin credentials

Follow up to https://github.com/gravitational/teleport/pull/48596
to remove the deprecated field now that
https://github.com/gravitational/teleport.e/pull/5373 has removed
the last usages.
---
 lib/config/configuration_test.go | 4 ----
 lib/config/fileconf.go           | 5 -----
 lib/service/servicecfg/auth.go   | 5 -----
 3 files changed, 14 deletions(-)

diff --git a/lib/config/configuration_test.go b/lib/config/configuration_test.go
index 83f6dbbf39991..02132c3ee1047 100644
--- a/lib/config/configuration_test.go
+++ b/lib/config/configuration_test.go
@@ -3670,10 +3670,6 @@ func TestAuthHostedPlugins(t *testing.T) {
 			applyErr: require.NoError,
 			assert: func(t *testing.T, p servicecfg.HostedPluginsConfig) {
 				require.True(t, p.Enabled)
-				require.NotNil(t, p.OAuthProviders.Slack)
-				require.Equal(t, "foo", p.OAuthProviders.Slack.ID)
-				require.Equal(t, "bar", p.OAuthProviders.Slack.Secret)
-
 				require.NotNil(t, p.OAuthProviders.SlackCredentials)
 				require.Equal(t, "foo", p.OAuthProviders.SlackCredentials.ClientID)
 				require.Equal(t, "bar", p.OAuthProviders.SlackCredentials.ClientSecret)
diff --git a/lib/config/fileconf.go b/lib/config/fileconf.go
index d221f46c461d0..a126af5c8dace 100644
--- a/lib/config/fileconf.go
+++ b/lib/config/fileconf.go
@@ -33,7 +33,6 @@ import (
 	"strings"
 	"time"
 
-	"github.com/coreos/go-oidc/oauth2"
 	"github.com/gravitational/trace"
 	log "github.com/sirupsen/logrus"
 	"golang.org/x/crypto/acme"
@@ -1321,10 +1320,6 @@ func (p *PluginOAuthProviders) Parse() (servicecfg.PluginOAuthProviders, error)
 		if err != nil {
 			return out, trace.Wrap(err)
 		}
-		out.Slack = &oauth2.ClientCredentials{
-			ID:     slack.ClientID,
-			Secret: slack.ClientSecret,
-		}
 		out.SlackCredentials = slack
 	}
 	return out, nil
diff --git a/lib/service/servicecfg/auth.go b/lib/service/servicecfg/auth.go
index 1ecc416e3c453..894f00ba95f91 100644
--- a/lib/service/servicecfg/auth.go
+++ b/lib/service/servicecfg/auth.go
@@ -21,7 +21,6 @@ package servicecfg
 import (
 	"slices"
 
-	"github.com/coreos/go-oidc/oauth2"
 	"github.com/dustin/go-humanize"
 	"github.com/gravitational/trace"
 	"github.com/jonboulle/clockwork"
@@ -178,10 +177,6 @@ type HostedPluginsConfig struct {
 // PluginOAuthProviders holds application credentials for each
 // 3rd party API provider
 type PluginOAuthProviders struct {
-	// TODO(tross) delete once teleport.e has been converted.
-	// Deprecated: use SlackCredentials instead.
-	Slack *oauth2.ClientCredentials
-
 	SlackCredentials *OAuthClientCredentials
 }