From 826500386d762d66d9a9766085f1399659c3fc3c Mon Sep 17 00:00:00 2001 From: Gus Rivera Date: Thu, 12 Sep 2024 12:51:17 -0500 Subject: [PATCH 1/7] Adding breaking change for mac packages --- CHANGELOG.md | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ea8dfcafa8f8c..4862d7c9ef57f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,8 +2,19 @@ ## 17.0.0 (11/xx/2024) -### ** Not yet released ** +### Breaking changes + +#### Mac Package Changes + +To support a more consistent user experience, Mac packages have been restructured so that all packages will provide a +`tsh` and `tctl` capable of utilizing TouchID + +All Mac packages now include `tsh.app` and `tctl.app` bundles and the standalone binaries for `tsh` and `tctl` have been removed. +The standalone `tsh.pkg` that installs a `tsh.app` bundle has also been removed as part of these changes since it is now included +by default in all packages. +`/usr/local/bin/tsh` will now be a symbolic link to `/Applications/tsh.app/Contents/MacOS/tsh` +`/usr/local/bin/tctl` will now be a symbolic link to `/Applications/tsh.app/Contents/MacOS/tctl` ## 16.4.6 (10/22/2024) From 84b78fe630e801b9141c923d62599fb276e2984b Mon Sep 17 00:00:00 2001 From: Gus Rivera Date: Fri, 13 Sep 2024 10:57:29 -0500 Subject: [PATCH 2/7] Adding some testing for tctl and tsh touchid --- .github/ISSUE_TEMPLATE/testplan.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/testplan.md b/.github/ISSUE_TEMPLATE/testplan.md index c240bcbe1603e..cc86c152dac1a 100644 --- a/.github/ISSUE_TEMPLATE/testplan.md +++ b/.github/ISSUE_TEMPLATE/testplan.md @@ -1367,6 +1367,8 @@ rev. 1607, which is the exact minimum Windows version that we support. - [ ] `teleport` runs on the minimum supported macOS version - [ ] `tbot` runs on the minimum supported macOS version - [ ] Teleport Connect runs on the minimum supported macOS version +- [ ] `tsh touchid diag` shows positive results for all requirements +- [ ] `tctl touchid diag` shows positive results for all requirements ### Linux From 65e81fb25113a2c3847443651b8bc3cd1a3eaec2 Mon Sep 17 00:00:00 2001 From: Gus Rivera Date: Fri, 1 Nov 2024 14:15:01 -0500 Subject: [PATCH 3/7] Adding a little bit more to docs --- .github/ISSUE_TEMPLATE/testplan.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/testplan.md b/.github/ISSUE_TEMPLATE/testplan.md index cc86c152dac1a..7d5f47bb9a8b4 100644 --- a/.github/ISSUE_TEMPLATE/testplan.md +++ b/.github/ISSUE_TEMPLATE/testplan.md @@ -1368,7 +1368,7 @@ rev. 1607, which is the exact minimum Windows version that we support. - [ ] `tbot` runs on the minimum supported macOS version - [ ] Teleport Connect runs on the minimum supported macOS version - [ ] `tsh touchid diag` shows positive results for all requirements -- [ ] `tctl touchid diag` shows positive results for all requirements +- [ ] `tctl touchid diag` shows positive results for all requirements (tctl requires you to be authenticated to run) ### Linux From 8d72e569eb171695fdf73610f186e79541508665 Mon Sep 17 00:00:00 2001 From: Gus Rivera Date: Tue, 12 Nov 2024 15:12:06 -0600 Subject: [PATCH 4/7] Update CHANGELOG.md Co-authored-by: Zac Bergquist --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4862d7c9ef57f..bc275f24d0833 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,7 @@ #### Mac Package Changes To support a more consistent user experience, Mac packages have been restructured so that all packages will provide a -`tsh` and `tctl` capable of utilizing TouchID +`tsh` and `tctl` capable of utilizing TouchID. All Mac packages now include `tsh.app` and `tctl.app` bundles and the standalone binaries for `tsh` and `tctl` have been removed. The standalone `tsh.pkg` that installs a `tsh.app` bundle has also been removed as part of these changes since it is now included From cfb03fde9f0b099c21b2717ce1000546543f6309 Mon Sep 17 00:00:00 2001 From: Gus Rivera Date: Tue, 12 Nov 2024 15:12:12 -0600 Subject: [PATCH 5/7] Update CHANGELOG.md Co-authored-by: Zac Bergquist --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bc275f24d0833..996a5fe2ff7e4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ ### Breaking changes -#### Mac Package Changes +#### macOS Package Changes To support a more consistent user experience, Mac packages have been restructured so that all packages will provide a `tsh` and `tctl` capable of utilizing TouchID. From dec2bfcee57ba03890265d339c58fc7bdbd5d5ea Mon Sep 17 00:00:00 2001 From: Gus Rivera Date: Tue, 12 Nov 2024 15:12:18 -0600 Subject: [PATCH 6/7] Update CHANGELOG.md Co-authored-by: Zac Bergquist --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 996a5fe2ff7e4..0c01acb490a38 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ #### macOS Package Changes -To support a more consistent user experience, Mac packages have been restructured so that all packages will provide a +To support a more consistent user experience, the macOS packages have been restructured so that all packages will provide a `tsh` and `tctl` capable of utilizing TouchID. All Mac packages now include `tsh.app` and `tctl.app` bundles and the standalone binaries for `tsh` and `tctl` have been removed. From 551be5018a971a1f1c3e2d585884cd1207ab0b20 Mon Sep 17 00:00:00 2001 From: Gus Rivera Date: Tue, 12 Nov 2024 15:12:24 -0600 Subject: [PATCH 7/7] Update CHANGELOG.md Co-authored-by: Zac Bergquist --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0c01acb490a38..7c3471d51eb1d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,8 @@ To support a more consistent user experience, the macOS packages have been restructured so that all packages will provide a `tsh` and `tctl` capable of utilizing TouchID. -All Mac packages now include `tsh.app` and `tctl.app` bundles and the standalone binaries for `tsh` and `tctl` have been removed. +The standalone `tsh` and `tctl` binaries have been removed from these packages and +replaced with `tsh.app` and `tctl.app` bundles. The standalone `tsh.pkg` that installs a `tsh.app` bundle has also been removed as part of these changes since it is now included by default in all packages.