Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include SAML IdP service provider preset value in unified resource view response #43446

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

flyinghermit
Copy link
Contributor

In unified resource view, SAML applications are set to Web UI as "App" type.

This PR updates:

  • ui.App type to include SAML service provider preset value. The preset value will be useful to render correct view for SAML application update flow.
  • The types.SAMLIdPServiceProvider type to ui.App converter to include SAML preset value.

Part of https://github.com/gravitational/teleport.e/issues/4458

@flyinghermit flyinghermit added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 labels Jun 24, 2024
@github-actions github-actions bot requested review from gabrielcorado and r0mant June 24, 2024 22:18
@flyinghermit
Copy link
Contributor Author

Friendly ping.

@flyinghermit flyinghermit added this pull request to the merge queue Jun 26, 2024
Merged via the queue into master with commit c44530d Jun 26, 2024
38 of 39 checks passed
@flyinghermit flyinghermit deleted the sshah/include-saml-preset branch June 26, 2024 14:43
@public-teleport-github-review-bot

@flyinghermit See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 backport/branch/v16 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants