Display websocket errors in the UI #43433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never implemented UI support for the websocket error message, so errors were never surfaced to users. This also uncovered one case where we were sending invalid data (due to a missing version number). Closes #42626
AntonAM
approved these changes
Jun 24, 2024
|
@AntonAM can you help out on this one? I think we need to do 2 things from the kube side:
Both of these can (and should) be done in a separate PR, since kube exec is only in v16, I just don't want us to lose track ofit.
|
|
@zmb3 yep, I'll look into this, It was already on my radar 👍 |
rosstimothy
approved these changes
Jun 25, 2024
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never implemented UI support for the websocket error message, so errors were never surfaced to users.
This also uncovered one case where we were sending invalid data (due to a missing version number).
Closes #42626
Changelog: Display errors in the web UI console for SSH and Kubernetes sessions.