[v15] auth: require a semaphore in order to complete uploads #41103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having multiple auth servers attempt to complete uploads against the same shared backend results in racy behavior. This code is focused on cleanup and is not performance sensitive, so we leverage a semaphore to make sure only one auth server is attempting to complete uploads at any point in time. This new behavior can be disabled with an environment variable, which will provide an escape hatch in case we we encounter problems with it.
github-actions
bot
added
audit-log
rosstimothy
approved these changes
May 1, 2024
marcoandredinis
approved these changes
May 3, 2024
public-teleport-github-review-bot
bot
removed the request for review
from fspmarshall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #40926 to branch/v15
changelog: Improve the reliability of the upload completer.