From fcb75ba2e33526e0f6e289fd2eec444a58485238 Mon Sep 17 00:00:00 2001
From: Przemko Robakowski <przemko.robakowski@goteleport.com>
Date: Fri, 15 Nov 2024 15:25:52 +0100
Subject: [PATCH] add access check test

---
 .../dynamicwindowsv1/service_test.go          | 56 +++++++++++++++++--
 1 file changed, 50 insertions(+), 6 deletions(-)

diff --git a/lib/auth/dynamicwindows/dynamicwindowsv1/service_test.go b/lib/auth/dynamicwindows/dynamicwindowsv1/service_test.go
index d212afac05698..8ae55acf040a0 100644
--- a/lib/auth/dynamicwindows/dynamicwindowsv1/service_test.go
+++ b/lib/auth/dynamicwindows/dynamicwindowsv1/service_test.go
@@ -37,6 +37,43 @@ import (
 	"github.com/gravitational/teleport/lib/utils"
 )
 
+func TestFailedAccessCheck(t *testing.T) {
+	t.Parallel()
+	checker := fakeChecker{
+		allowedVerbs: []string{types.VerbRead, types.VerbList, types.VerbCreate, types.VerbUpdate},
+	}
+	s := newService(t, authz.AdminActionAuthMFAVerified, &checker)
+	desktop, err := types.NewDynamicWindowsDesktopV1("test2", nil, types.DynamicWindowsDesktopSpecV1{Addr: "addr"})
+	require.NoError(t, err)
+	req := dynamicwindowsv1.CreateDynamicWindowsDesktopRequest{
+		Desktop: desktop,
+	}
+	_, err = s.CreateDynamicWindowsDesktop(context.Background(), &req)
+	require.NoError(t, err)
+	checker.failAccess = true
+	testCases := []string{
+		"CreateDynamicWindowsDesktop",
+		"UpdateDynamicWindowsDesktop",
+		"UpsertDynamicWindowsDesktop",
+		"DeleteDynamicWindowsDesktop",
+		"GetDynamicWindowsDesktop",
+	}
+	for _, tt := range testCases {
+		t.Run(fmt.Sprintf("%s failed access check", tt), func(t *testing.T) {
+			err := callMethod(s, tt)
+			require.True(t, trace.IsAccessDenied(err))
+		})
+	}
+	t.Run("ListDynamicWindowsDesktops failed access check", func(t *testing.T) {
+		req := dynamicwindowsv1.ListDynamicWindowsDesktopsRequest{
+			PageSize: 10,
+		}
+		resp, err := s.ListDynamicWindowsDesktops(context.Background(), &req)
+		require.NoError(t, err)
+		require.Empty(t, resp.Desktops)
+	})
+}
+
 func TestServiceAccess(t *testing.T) {
 	t.Parallel()
 
@@ -87,7 +124,7 @@ func TestServiceAccess(t *testing.T) {
 		for _, state := range tt.allowedStates {
 			for _, verbs := range utils.Combinations(tt.allowedVerbs) {
 				t.Run(fmt.Sprintf("%v,allowed:%v,verbs:%v", tt.name, stateToString(state), verbs), func(t *testing.T) {
-					service := newService(t, state, fakeChecker{allowedVerbs: verbs})
+					service := newService(t, state, &fakeChecker{allowedVerbs: verbs})
 					err := callMethod(service, tt.name)
 					// expect access denied except with full set of verbs.
 					if len(verbs) == len(tt.allowedVerbs) {
@@ -105,7 +142,7 @@ func TestServiceAccess(t *testing.T) {
 			t.Run(fmt.Sprintf("%v,disallowed:%v", tt.name, stateToString(state)), func(t *testing.T) {
 				// it is enough to test against tt.allowedVerbs,
 				// this is the only different data point compared to the test cases above.
-				service := newService(t, state, fakeChecker{allowedVerbs: tt.allowedVerbs})
+				service := newService(t, state, &fakeChecker{allowedVerbs: tt.allowedVerbs})
 				err := callMethod(service, tt.name)
 				require.True(t, trace.IsAccessDenied(err))
 			})
@@ -157,16 +194,19 @@ func callMethod(service *Service, method string) error {
 		if desc.MethodName == method {
 			_, err := desc.Handler(service, context.Background(), func(arg any) error {
 				switch arg := arg.(type) {
+				case *dynamicwindowsv1.GetDynamicWindowsDesktopRequest:
+					arg.Name = "test2"
+
 				case *dynamicwindowsv1.CreateDynamicWindowsDesktopRequest:
 					arg.Desktop, _ = types.NewDynamicWindowsDesktopV1("test", nil, types.DynamicWindowsDesktopSpecV1{
 						Addr: "test",
 					})
 				case *dynamicwindowsv1.UpdateDynamicWindowsDesktopRequest:
-					arg.Desktop, _ = types.NewDynamicWindowsDesktopV1("test", nil, types.DynamicWindowsDesktopSpecV1{
+					arg.Desktop, _ = types.NewDynamicWindowsDesktopV1("test2", nil, types.DynamicWindowsDesktopSpecV1{
 						Addr: "test",
 					})
 				case *dynamicwindowsv1.UpsertDynamicWindowsDesktopRequest:
-					arg.Desktop, _ = types.NewDynamicWindowsDesktopV1("test", nil, types.DynamicWindowsDesktopSpecV1{
+					arg.Desktop, _ = types.NewDynamicWindowsDesktopV1("test2", nil, types.DynamicWindowsDesktopSpecV1{
 						Addr: "test",
 					})
 				}
@@ -180,10 +220,11 @@ func callMethod(service *Service, method string) error {
 
 type fakeChecker struct {
 	allowedVerbs []string
+	failAccess   bool
 	services.AccessChecker
 }
 
-func (f fakeChecker) CheckAccessToRule(_ services.RuleContext, _ string, resource string, verb string) error {
+func (f *fakeChecker) CheckAccessToRule(_ services.RuleContext, _ string, resource string, verb string) error {
 	if resource == types.KindDynamicWindowsDesktop {
 		if slices.Contains(f.allowedVerbs, verb) {
 			return nil
@@ -193,7 +234,10 @@ func (f fakeChecker) CheckAccessToRule(_ services.RuleContext, _ string, resourc
 	return trace.AccessDenied("access denied to rule=%v/verb=%v", resource, verb)
 }
 
-func (f fakeChecker) CheckAccess(r services.AccessCheckable, state services.AccessState, matchers ...services.RoleMatcher) error {
+func (f *fakeChecker) CheckAccess(r services.AccessCheckable, state services.AccessState, matchers ...services.RoleMatcher) error {
+	if f.failAccess {
+		return trace.AccessDenied("denied")
+	}
 	return nil
 }