From e58e489419d23fffbf6006d2a5420ee8fcec00a3 Mon Sep 17 00:00:00 2001
From: Lisa Kim <lisa@goteleport.com>
Date: Thu, 14 Nov 2024 11:32:42 -0800
Subject: [PATCH] Web discover minor fixes (#48862)

* Remove optional wording (no longer optional)

* Fix incorrect log app name

* Show already exists error messages instead of making it seem we are still searching

* Address CRs
---
 .../DeployService/AutoDeploy/AutoDeploy.tsx   |  2 +-
 .../EnrollEKSCluster/AgentWaitingDialog.tsx   |  4 +-
 .../EnrollEksCluster.story.tsx                | 40 +++++++++++++++++--
 .../EnrollEKSCluster/EnrollEksCluster.tsx     | 30 +++++++++-----
 .../EnrollEKSCluster/EnrollmentDialog.tsx     |  9 +++--
 5 files changed, 67 insertions(+), 18 deletions(-)

diff --git a/web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/AutoDeploy.tsx b/web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/AutoDeploy.tsx
index 9439b9a174b93..79a0355e73816 100644
--- a/web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/AutoDeploy.tsx
+++ b/web/packages/teleport/src/Discover/Database/DeployService/AutoDeploy/AutoDeploy.tsx
@@ -249,7 +249,7 @@ export function AutoDeploy({ toggleDeployMethod }: DeployServiceProp) {
 
             <StyledBox mb={5}>
               <header>
-                <H3>Step 3 (Optional)</H3>
+                <H3>Step 3</H3>
               </header>
               <SelectSecurityGroups
                 selectedSecurityGroups={selectedSecurityGroups}
diff --git a/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/AgentWaitingDialog.tsx b/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/AgentWaitingDialog.tsx
index 177c280826dd2..b36c2a345f618 100644
--- a/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/AgentWaitingDialog.tsx
+++ b/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/AgentWaitingDialog.tsx
@@ -94,7 +94,9 @@ export function AgentWaitingDialog({
               - The Teleport Service could not join this Teleport cluster. Check
               the logs for errors by running
               <br />
-              <Mark>kubectl logs -l app=teleport-agent -n teleport-agent</Mark>
+              <Mark>
+                kubectl logs -l app=teleport-kube-agent -n teleport-agent
+              </Mark>
             </Text>
 
             <Text>
diff --git a/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/EnrollEksCluster.story.tsx b/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/EnrollEksCluster.story.tsx
index 9d56b991445f9..06dd72cf882ad 100644
--- a/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/EnrollEksCluster.story.tsx
+++ b/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/EnrollEksCluster.story.tsx
@@ -165,7 +165,6 @@ WithAwsPermissionsError.parameters = {
 };
 
 export const WithEnrollmentError = () => <Component />;
-
 WithEnrollmentError.parameters = {
   msw: {
     handlers: [
@@ -194,6 +193,39 @@ WithEnrollmentError.parameters = {
   },
 };
 
+export const WithAlreadyExistsError = () => (
+  <Component devInfoText="select any region, select EKS1 to see already exist error" />
+);
+WithAlreadyExistsError.parameters = {
+  msw: {
+    handlers: [
+      tokenHandler,
+      http.post(cfg.getListEKSClustersUrl(integrationName), () => {
+        {
+          return HttpResponse.json({ clusters: eksClusters });
+        }
+      }),
+      http.get(
+        cfg.getKubernetesUrl(getUserContext().cluster.clusterId, {}),
+        () => {
+          return HttpResponse.json({ items: kubeServers });
+        }
+      ),
+      http.post(cfg.getEnrollEksClusterUrl(integrationName), async () => {
+        await delay(1000);
+        return HttpResponse.json({
+          results: [
+            {
+              clusterName: 'EKS1',
+              error: 'teleport-kube-agent is already installed on the cluster',
+            },
+          ],
+        });
+      }),
+    ],
+  },
+};
+
 export const WithOtherError = () => <Component />;
 
 WithOtherError.parameters = {
@@ -212,7 +244,7 @@ WithOtherError.parameters = {
   },
 };
 
-const Component = () => {
+const Component = ({ devInfoText = '' }) => {
   const ctx = createTeleportContext();
   const discoverCtx: DiscoverContextState = {
     agentMeta: {
@@ -268,7 +300,9 @@ const Component = () => {
           resourceKind={ResourceKind.Kubernetes}
         >
           <DiscoverProvider mockCtx={discoverCtx}>
-            <Info>Devs: Select any region to see story state</Info>
+            <Info>
+              {devInfoText || 'Devs: Select any region to see story state'}
+            </Info>
             <EnrollEksCluster
               nextStep={discoverCtx.nextStep}
               updateAgentMeta={discoverCtx.updateAgentMeta}
diff --git a/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/EnrollEksCluster.tsx b/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/EnrollEksCluster.tsx
index aadb78d3af559..e73fc6dfc3e15 100644
--- a/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/EnrollEksCluster.tsx
+++ b/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/EnrollEksCluster.tsx
@@ -95,7 +95,13 @@ export type CheckedEksCluster = AwsEksCluster & {
 };
 
 type EKSClusterEnrollmentState = {
-  status: 'notStarted' | 'enrolling' | 'awaitingAgent' | 'success' | 'error';
+  status:
+    | 'notStarted'
+    | 'enrolling'
+    | 'awaitingAgent'
+    | 'success'
+    | 'error'
+    | 'alreadyExists';
   error?: string;
 };
 
@@ -302,16 +308,19 @@ export function EnrollEksCluster(props: AgentStepProps) {
         emitErrorEvent(
           'unknown error: no results came back from enrolling the EKS cluster.'
         );
-      } else if (
-        result.error &&
-        !result.error.includes(
-          'teleport-kube-agent is already installed on the cluster'
-        )
-      ) {
-        setEnrollmentState({
+      } else if (result.error) {
+        const errorState: EKSClusterEnrollmentState = {
           status: 'error',
           error: `Cluster enrollment error: ${result.error}`,
-        });
+        };
+        if (
+          result.error.includes(
+            'teleport-kube-agent is already installed on the cluster'
+          )
+        ) {
+          errorState.status = 'alreadyExists';
+        }
+        setEnrollmentState(errorState);
         emitErrorEvent(`failed to enroll EKS cluster: ${result.error}`);
       } else {
         setEnrollmentState({ status: 'awaitingAgent' });
@@ -515,7 +524,8 @@ export function EnrollEksCluster(props: AgentStepProps) {
         </Box>
       )}
       {(enrollmentState.status === 'enrolling' ||
-        enrollmentState.status === 'error') && (
+        enrollmentState.status === 'error' ||
+        enrollmentState.status === 'alreadyExists') && (
         <EnrollmentDialog
           clusterName={selectedCluster.name}
           close={closeEnrollmentDialog}
diff --git a/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/EnrollmentDialog.tsx b/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/EnrollmentDialog.tsx
index a19c031891af5..3d7aa5a92570c 100644
--- a/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/EnrollmentDialog.tsx
+++ b/web/packages/teleport/src/Discover/Kubernetes/EnrollEKSCluster/EnrollmentDialog.tsx
@@ -63,6 +63,7 @@ export function EnrollmentDialog({
         );
 
       case 'error':
+      case 'alreadyExists':
         return (
           <>
             <Flex mb={5} alignItems="center">
@@ -70,9 +71,11 @@ export function EnrollmentDialog({
               <Text>{error}</Text>
             </Flex>
             <Flex gap={4}>
-              <ButtonPrimary width="50%" onClick={retry}>
-                Retry
-              </ButtonPrimary>
+              {status === 'error' && (
+                <ButtonPrimary width="50%" onClick={retry}>
+                  Retry
+                </ButtonPrimary>
+              )}
               <ButtonSecondary width="50%" onClick={close}>
                 Close
               </ButtonSecondary>