Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

"Export as CSV" link on ~user History yields blank CSV file #4399

Closed
mattbk opened this issue Apr 6, 2017 · 8 comments
Closed

"Export as CSV" link on ~user History yields blank CSV file #4399

mattbk opened this issue Apr 6, 2017 · 8 comments
Assignees
Labels

Comments

@mattbk
Copy link
Contributor

mattbk commented Apr 6, 2017

https://gratipay.com/about/me/history/

image

@mattbk mattbk added the Bug label Apr 6, 2017
@EdOverflow
Copy link
Contributor

Just out of interest, what is exported to a CSV file? Is it only the amount or are recipient names included?

@mattbk
Copy link
Contributor Author

mattbk commented Apr 6, 2017

https://github.com/gratipay/gratipay.com/blob/4b5b0b3e287424a3e5b4179d49eddac44064f7e4/www/~/%25username/history/export.spt

Looks like
participant, year, mode

@EdOverflow
Copy link
Contributor

HackerOne report on its way...

@EdOverflow
Copy link
Contributor

The report can be found here: https://hackerone.com/reports/219323

@rohitpaulk
Copy link
Contributor

The problem here is that the new Gratipay 2.x changes haven't been carried over properly - we're only considering transfers (Gratipay 1.0), not payments (Gratipay 2.x)

@rohitpaulk
Copy link
Contributor

Might need a few changes in the JSON structure - tipper/tippee isn't valid terminology anymore.

screen shot 2017-05-03 at 8 49 14 pm

@rohitpaulk
Copy link
Contributor

Also, aggregate is the only mode used, although we support output of individual exchanges and transfers if the parameter isn't supplied. Looks like an undocumented feature, I don't think it is worth maintaining as of now.

@rohitpaulk rohitpaulk self-assigned this May 3, 2017
chadwhitacre added a commit that referenced this issue May 4, 2017
@mattbk
Copy link
Contributor Author

mattbk commented May 5, 2017

Fixed in #4439.

@mattbk mattbk closed this as completed May 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants