-
Notifications
You must be signed in to change notification settings - Fork 308
subscriptions.json #3460
Comments
This should be blocked by the fact that a team page is needed before we add a subscription this widget to the team page (that does not currently exist). |
!m @kaguillera |
I found a pretty nice way (IMO) to write literate APIs, but it got buried in a dead-end PR (see #3786 (comment) and, e.g., |
Woah, that's some nice stuff :) |
Thanks! :-) I thought it was a really interesting way to use simplates to integrate the API and documentation with the site itself. |
Thinking of working on this next. Can someone point me in the right direction? :) |
@aandis - So I poked up the the oldest tag (version) we have - https://github.com/gratipay/gratipay.com/tree/1840 I'd start by looking at You could try checking out that version of the codebase, firing up the server and actually hitting the API to understand what it does - and maybe suggest improvements too :) |
As of now, we want this information to be restricted to users via API keys - but in the future (if we land #236) it might make sense to expose some/all of this information publicly. |
There was some nice stuff that people built on top of that endpoint, you might find them interesting - http://ejohn.org/blog/gittip-at-khan-academy/ |
Cool! In the meanwhile, I managed to dig up tips.json before it got removed. From the looks of it, it offers |
I was wondering what the use case of this was. Thanks for pointing this out! :) |
It could also come in handy if you (we) decide to build an android app for Gratipay ;) |
That is more than enough to get me excited with this! :) |
https://github.com/gratipay/gratipay.com/blob/master/www/%25team/payment-instruction.json.spt Isn't this what this ticket is about? |
That comes close, yes (it's no documented though, just used internally). One thing that lacks with that endpoint is - a user can't hit an endpoint to see all the subscriptions they've set up. If they know that they've setup a subscription to a certain team, then this endpoint could be useful. In fact, we could just add an endpoint to view all subscriptions Now that you know the functionality we intend to provide, what do you think is the best API design? |
Ummm ok..
How does that sound? |
I think we'd want that to be the team slug :) This filtering is secondary though, as long as we expose all information through the batch endpoint (number 1, in your comment above)
You mean internal redirection and not client-side (via HTTP headers), right? The above structure sounds good to me - Just 1 and 3 would do, in fact :) Thoughts? cc: @whit537 |
Yes. Although I am not entirely sure how this would work because I was playing around with I am still to test it with the current version though. I'll get started with this today and hopefully this doesn't happen. |
One thing we had on the old |
@aandis Note that https://github.com/gratipay/gratipay.com/blob/1831/www/~/%25username/tips.json.spt |
Yep! I checked out both of them earlier. Working on |
Cool. In #3460 (comment) you mentioned !m @aandis |
!m @aandis |
One ticket closer to landing the Pivot! :D P.S. For context, we carved the Team Basics milestone out of the Pivot milestone at gratipay/inside.gratipay.com#383 (comment). |
We killed the tips.json API somewhere beneath #3399. We need to bring back a parallel API for
subscriptions
.The text was updated successfully, but these errors were encountered: