Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

update payday self-checks to exclude manual exchanges #2291

Closed
chadwhitacre opened this issue Apr 17, 2014 · 4 comments · Fixed by #2292
Closed

update payday self-checks to exclude manual exchanges #2291

chadwhitacre opened this issue Apr 17, 2014 · 4 comments · Fixed by #2292

Comments

@chadwhitacre
Copy link
Contributor

Reticketing from #2290.

@chadwhitacre
Copy link
Contributor Author

I added and recorder is null to the four relevant queries. That fixed the first query in the function but now the third is choking on an old payday.

@chadwhitacre
Copy link
Contributor Author

My hypothesis is that we repaired the paydays script in the past using a query that didn't exclude manually recorded exchanges. Now, don't we want to include manually-recorded exchanges in the payday withdrawals figure? MassPay falls under this category (recorder is not null) and we want that reflected somehow.

@chadwhitacre
Copy link
Contributor Author

That would require changes to payday.py and for now we really just need to fix the self-checks so we can get #2290 back on track.

@chadwhitacre
Copy link
Contributor Author

Repaired in production with update paydays set ach_volume =-1885.73 where id=74;.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant