take_over should clear credit card on file

[zbynekwinkler]

We used to have a bug in take_over code that resulted in some self tips not being properly cleared. We also do not clear the credit card on file for the dead account. A combination of these 2 caused us to charge credit card for 4 weeks of an account the user had no chance to log in and turn it of.

Found at #1705 (comment)

[chadwhitacre]

@martindale You're the affected user here. We owe you the fees on those charges. Sorry for the mistake. :-(

[chadwhitacre]

Finally getting to this. The situation is that @martindale was tipping himself from a second account, then folded the second into the first. The tip kept going from the second account to the first for four more weeks. I don't know why the tip stopped at that point (some action @zwn took? some action @martindale took? a credit card failure?). Since @martindale was tipping himself, he ended up with the tip itself, but we owe him for the fees. At the time we were charging for payouts as well as payins, so we owe @martindale $1.25 per payin and $0.30 per payout between Gittip 38 (February 14, 2013) and Gittip 43 (March 22, 2013), inclusive. That's six paydays, but I'm only seeing four payins/payouts (credit card failures for the other two?).

I've done a one-off transfer of $6.20 from Gittip to martindale.

[chadwhitacre]

IRC

[chadwhitacre]

Per #2504 (comment), the way we want to fix this is to invalidate all funding instruments on Balanced, but keep the connection to the Balanced account. Once we have balanced/balanced-dashboard#1353 we'll be able to see invalidated instruments on a Balanced account page for historical/debugging purposes.

[chadwhitacre]

In the mean time I've invalidated @martindale's card in Balanced for his old account.

[chadwhitacre]

Actually, I'm confused. This issue is about handling funding instruments in the the take_over case, and is therefore a duplicate of #941. I've reticketed invalidating instruments during account close as #2567.