Unknown accounts giving money every week...

[mvdkleijn]

We have accounts listed as "???" giving money every week. See https://www.gittip.com/?limit=1000

Is that a side effect of the "hide my giving from others" option? If so, I think it would look a whole lot better to have a nicer default picture and a name like "Anonymous" instead of "???".

The question marks just look like a bug.

[tshepang]

Yes, it's the case of anonymous giving. I agree that we need something more informative.

[mvdkleijn]

Added a simple PR that will changes ??? into Anonymous.

@whit537 Do we perhaps want a nice(r) default image for the avatar?

[mvdkleijn]

@tshepang I named it Anonymous in my PR, but just realized that "Private Patron" or something like that might sound nicer? 😄

[tshepang]

@mvdkleijn me prefers anonymous; I think more people would understand it than they would private patron

[mvdkleijn]

Then unless @whit537 or someone else prefers to use a nicer avatar image for anonymous benefactors, PR #1421 is ready for merge. Want to review and merge?

[seanlinsley]

@mvdkleijn I think what you're describing is #617, because as far as I know there is no such thing as an anonymous account. You're anonymous in the eyes of the receiver, but that's it.

[chadwhitacre]

The one issue with "anonymous" is that if there's only one on the page, it can be construed as all anonymous givers lumped together.

[seanlinsley]

@whit537 am I wrong in my deduction?

[mvdkleijn]

@daxter that's not what I meant. I already added a pull request for what I described. Check it out.

[seanlinsley]

I saw the PR, but that doesn't address my question. Quoting myself:

@mvdkleijn I think what you're describing is #617, because as far as I know there is no such thing as an anonymous account. You're anonymous in the eyes of the receiver, but that's it.

If they aren't orphaned accounts, I'd appreciate if someone could explain what exactly they are.

[seanlinsley]

Also: https://github.com/gittip/www.gittip.com/blob/aff698d5d6655bae5c7e79d207aa12ede90e330e/www/index.html.spt#L47-L48

[mvdkleijn]

@daxter Ah sorry... I interpreted your remark incorrectly. I'll explain:

The top givers listing on the front page does this check:

{% if giver.anonymous and not user.ADMIN %}

If this check is true, in other words someone is anonymous and not admin, the system displayed "???" as the hardcoded username. This change would display "Anonymous" instead.

As far as I can tell, this is purely based on the "hide my giving from others" setting and as such not related to the orphaned accounts problems. (orphaned accounts have usernames in the style of "d6b62b6b95c9" and can have or not have the "hide my giving" setting active)

[seanlinsley]

Ah... I hadn't considered the "hide my giving" setting might cause this. Thanks for the explanation!

[mvdkleijn]

@daxter No problem 😄 Closing this issue since the PR was merged.