Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Customize SimpleDataFetcherExceptionHandler to avoid logException for certain errors #897

Open
williamwjs opened this issue Nov 30, 2022 · 1 comment

Comments

@williamwjs
Copy link

Is your feature request related to a problem? Please describe.
In our app, it is normal and expected to have non-login users accessing the pages, where we will return as auth error for some queries. It is annoying to always log the stacktrace for such cases.

Graphql-Java made that a protected method so that we could override it with our own logic:
https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/execution/SimpleDataFetcherExceptionHandler.java#L40-L48

However, it is not easy to embed it with kickstart library right now.

Describe the solution you'd like
Expecting a non-required bean for DataFetcherExceptionHandler, so that it could be passed into the below places when building Execution strategy:

return new DefaultExecutionStrategyProvider(new AsyncExecutionStrategy(), null,
new SubscriptionExecutionStrategy());

Describe alternatives you've considered
As a workaround, I have to provide my own bean for executionStrategies, which I feel is too much layer above:

@williamwjs
Copy link
Author

A related question: May I also ask why line 177 gives null for mutationExecutionStrategy?

return new DefaultExecutionStrategyProvider(new AsyncExecutionStrategy(), null,
new SubscriptionExecutionStrategy());

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant