New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to service classes in the src/test/java #173

Open

ashpak-shaikh opened this issue Oct 20, 2023 · 1 comment

Assignees

Labels

enhancement good first issue hacktoberfest hacktoberfest2023

Contributor

ashpak-shaikh commented Oct 20, 2023 •

edited

Loading

With the migration to groovy style tests, we do not need the test service classes in test/java. The services are in the following package https://github.com/graph-quilt/graphql-orchestrator-java/tree/master/src/test/java/com/intuit/graphql/orchestrator
An example would be BookService

Delete these service class and migrate all the test referring to these services to groovy. Example of groovy test
https://github.com/graph-quilt/graphql-orchestrator-java/blob/master/src/test/groovy/com/intuit/graphql/orchestrator/integration/TopLevelStitchingSpec.groovy
More tests in this package

ashpak-shaikh added enhancement hacktoberfest good first issue labels

Contributor

tasneemkoushar commented Oct 20, 2023

@ashpak-shaikh can I take this issue?

ashpak-shaikh assigned tasneemkoushar

ashpak-shaikh added the hacktoberfest2023 label

tasneemkoushar mentioned this issue

fix: made changes for service A, B, C, D, E #187

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment