Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] product_label #159

Merged
merged 36 commits into from
Nov 15, 2024

Conversation

quentinDupont
Copy link
Member

@quentinDupont quentinDupont commented Jul 10, 2024

Migration car utile ensuite pour un module mrp_bom_label truc

legalsylvain and others added 30 commits July 10, 2024 11:02
* [MIG] sale_food (automatic operations)
* [MIG] sale_food :
- extract product_origin
- extract product_origin_l10n_fr_department
- pre-dependency to web_domain_field
- extract product_label
- extract product_food
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.68%. Comparing base (3f1a180) to head (e94b3e5).
Report is 50 commits behind head on 16.0.

Files with missing lines Patch % Lines
product_label/models/product_label.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             16.0     #159      +/-   ##
==========================================
+ Coverage   89.25%   89.68%   +0.42%     
==========================================
  Files          37       47      +10     
  Lines         754      824      +70     
  Branches      107      112       +5     
==========================================
+ Hits          673      739      +66     
- Misses         55       58       +3     
- Partials       26       27       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peut-etre qu'il faut mettre à jour le fr.po.

sinon, top !

Comment on lines +45 to +47
image_medium = fields.Image(
related="image", max_width=512, max_height=512, store=True
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est la nouvelle syntaxe en V16 qui recompute automatiquement ? (et plus besoin d'appeler image_resize_images ?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouep ! related de l'image de base + max_width et max_height qui recompute le truc !

@legalsylvain legalsylvain added this to the 16.0 milestone Nov 15, 2024
…remarks

16.0 imp product label sandy remarks
@legalsylvain
Copy link
Member

legalsylvain commented Nov 15, 2024

MeP du 14/11/2024

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-159-by-legalsylvain-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit 8a01e26 into grap:16.0 Nov 15, 2024
4 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 0cd2b20. Thanks a lot for contributing to grap. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants