[common] Refactor Protected Files, part 1 #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimakuv
force-pushed
the
dimakuv/protected-files-cleanup-part1
branch
from
7f3f02d to
7ae2335
Compare
This was referenced May 2, 2024
mkow
approved these changes
May 2, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
kailun-qin
approved these changes
May 2, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
This commit refactors PF code without changing functionality (part 1 in a series of commits). In particular, this commit removes unused functions, variables, fields, typedefs and macros. Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
mkow
force-pushed
the
dimakuv/protected-files-cleanup-part1
branch
from
7ae2335 to
6d2ee63
Compare
mkow
approved these changes
May 4, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
kailun-qin
approved these changes
May 4, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
This commit refactors PF code without changing functionality (part 1 in a series of commits). In particular, this commit removes unused functions, variables, fields, typedefs and macros.
Extracted from #1841 at the request of @mkow.
How to test this PR?
N/A.
This change is