Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove dependency on grails-shell #350

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

matrei
Copy link
Contributor

@matrei matrei commented Mar 7, 2024

Grails-shell is deprecated for removal.

Grails-shell is deprecated for removal.
@matrei
Copy link
Contributor Author

matrei commented Mar 7, 2024

@guillermocalvo I think we can just remove any references to grails-shell. I think the handle(ExecutionContext) method was only called by the scripts (that are no longer used).

@guillermocalvo
Copy link
Contributor

@guillermocalvo I think we can just remove any references to grails-shell. I think the handle(ExecutionContext) method was only called by the scripts (that are no longer used).

@matrei Thanks! In fact, I think we can delete all those unused files. I cannot push changes directly because I don't seem to have permissions on this repo, so I just opened a PR against your fork: matrei#1

@matrei
Copy link
Contributor Author

matrei commented Mar 7, 2024

@guillermocalvo 👍 I think you're right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants