Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'JamfPackageUploader' object has no attribute 'reboot_required' #180

Open
davidbpirie opened this issue Nov 27, 2024 · 2 comments
Open

'JamfPackageUploader' object has no attribute 'reboot_required' #180

davidbpirie opened this issue Nov 27, 2024 · 2 comments
Assignees
Labels
answered Answered, awaiting response if required (will be closed after a while if no response given) bug Something isn't working

Comments

@davidbpirie
Copy link
Contributor

davidbpirie commented Nov 27, 2024

I am trying out your md5 branch for the JamfPackageUploader, and am getting an error:

'JamfPackageUploader' object has no attribute 'reboot_required'

I get this regardless of what value I set for reboot_required e.g. -k reboot_required="False"

From looking at your code, I think it is just an error in JamfPackageUploaderBase.py at line 945:
if not reboot_required or self.reboot_required == "False":
which should be:
if not reboot_required or reboot_required == "False":
since you are never creating an object property named reboot_required, just using a local variable.

@grahampugh
Copy link
Owner

Thanks, yes that's right. I took the opportunity to remove all the "self" objects which were unnecessary and were causing my linting tools to complain. But clearly missed this one. I'll fix it today.

@grahampugh
Copy link
Owner

This should be fixed now. Thanks again for the spot.

@grahampugh grahampugh self-assigned this Nov 27, 2024
@grahampugh grahampugh added bug Something isn't working answered Answered, awaiting response if required (will be closed after a while if no response given) labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered Answered, awaiting response if required (will be closed after a while if no response given) bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants