-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Update overrides content in Helm chart to clarify configuration for new, legacy #3820
Comments
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. |
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. |
Mario found an issue in the tempo-distributed Helm chart that prevented the overrides examples from working. The issue was corrected in this PR: grafana/helm-charts#3236 |
There is an issue in the Helm chart that needs to be fixed. Outlined here: grafana/helm-charts#2802 (comment) The tempo-distributed Helm chart doesn't have the same implementation of the overrides as the standard Tempo configuration. The per tenant overrides is being implemented with the global overrides. The docs are correct, but how the overrides are implemented in the Helm chart is slightly different. We should update the tempo-distributed Helm chart documentation with a work around until this |
The README needs to have these updates:
|
Related Helm chart PRs that we might want to check: |
Update the overrides configuration documentation to address changes to the Overrides module. The configuration examples need to be checked to make sure they are for the updated overrdies and which ones are not.
Update these pages:
The configuratio file in this doc works, but it's a YAML file:
"A snippet of a config.yaml file showing how the overrides section is here.
Reference: #3795, grafana/helm-charts#2802 (comment)
Notes
Same issue happens in the tempo-distributed Helm chart:
As a rule of thumb: long, unindented params are legacy (eg.
metrics_generator_forwarder_queue_size
), indented params are new (eg.metrics_generator.forwarder.queue_size
).With the new config, a new key defaults was also added after the overrides key, to be more explicit of the contents of the config block.
Finally, there is a command in the tempo-cli that allows you to convert legacy config to new overrides config.
The text was updated successfully, but these errors were encountered: