Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-vault-secrets does not expose exportEnv #518

Open
mem opened this issue Nov 5, 2024 · 3 comments
Open

get-vault-secrets does not expose exportEnv #518

mem opened this issue Nov 5, 2024 · 3 comments

Comments

@mem
Copy link

mem commented Nov 5, 2024

The underlying hashicorp/vault-action has an input called exportEnv which defaults to true, which causes secrets to be exported as environment variables making them available in the environment to all subsequent steps. Because of the way the GitHub Actions environment works, these variables are available to all the processes started from these steps.

I would prefer to have the option to disable that behavior. hashicorp/vault-action has such an optoin (exportEnv: false) but does not expose that option.

@zerok
Copy link
Contributor

zerok commented Nov 6, 2024

Just to clarify: If that's enabled, the only way to access those secrets would be through the step's outputs, right?

@mem
Copy link
Author

mem commented Nov 11, 2024

Just to clarify: If that's enabled, the only way to access those secrets would be through the step's outputs, right?

Correct.

I would prefer to have the choice of opting out of the implicit behavior, meaning expose the exportEnv option from this action and default it to true, which is equivalent to the current behavior. In that way the user of this action can set it to false and opt out of this.

@zerok
Copy link
Contributor

zerok commented Nov 12, 2024

Sounds good 🙂 Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants