Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make opensearch traces limit settable #484

Open
zoesyc opened this issue Oct 30, 2024 · 3 comments
Open

Make opensearch traces limit settable #484

zoesyc opened this issue Oct 30, 2024 · 3 comments
Assignees

Comments

@zoesyc
Copy link

zoesyc commented Oct 30, 2024

Investigate the opensearch span limits and why traces are currently capped at a limit of 'the first 1000 spans' in the trace

Use Case: Teams can monitor complex systems which often result in traces that include over 1000 spans. What is the reason for the current cap?

@idastambuk
Copy link
Contributor

So as far as I can remember, there wasn't a particular reason, apart from that this is the limit in OpenSearch dashboards as well, and it cannot be overridden there either.
However, I think it makes sense for us to give the user the ability to override this limit of 1000, by providing an input for Span limit. Tempo datasource also has this.
They also have a separate input for number of traces returned. We could also provide the user that as well, though I'm not sure if there is need for this currently (it makes sense to me that there is greater need to not limit spans within a trace).
Adding this to backlog.

@idastambuk idastambuk moved this from Incoming to Next in AWS Datasources Nov 4, 2024
@DWebb0
Copy link

DWebb0 commented Nov 19, 2024

I'm registering my interest here. cc @annelaurefroment

@iwysiu iwysiu self-assigned this Jan 14, 2025
@iwysiu iwysiu moved this from Next to In Progress in AWS Datasources Jan 14, 2025
@iwysiu
Copy link
Contributor

iwysiu commented Jan 15, 2025

Investigation results: Based on both elasticsearch and opensearch docs, it seems like the actual limit is 10,000. From what I could tell, there isn't really any reason for our 1000 limit besides performance.
We can make it a configurable field and then just use the current 1000 as the default, I'll update the issue to reflect that.

@iwysiu iwysiu changed the title Investigate opensearch span limits Make opensearch traces limit settable Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

4 participants