Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade gopsutil #14542

Merged
merged 1 commit into from
Oct 22, 2024
Merged

chore: upgrade gopsutil #14542

merged 1 commit into from
Oct 22, 2024

Conversation

trevorwhitney
Copy link
Collaborator

@trevorwhitney trevorwhitney commented Oct 18, 2024

What this PR does / why we need it:

shirou/gopsutil#1734 seems to be related to setting CGO_ENABLED=0, and therefore can be mitigated and we can re-upgrade.

More context: #14437

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney requested a review from a team as a code owner October 18, 2024 21:38
@trevorwhitney trevorwhitney force-pushed the bring-back-gopsutil-4.24.9 branch from 92411b5 to 08115c3 Compare October 18, 2024 21:40
@trevorwhitney trevorwhitney merged commit 12cd12a into main Oct 22, 2024
63 checks passed
@trevorwhitney trevorwhitney deleted the bring-back-gopsutil-4.24.9 branch October 22, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants