Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Default loki-mixin dashboards to TSDB #9772

Open
trevorwhitney opened this issue Jun 22, 2023 · 9 comments
Open

[Task] Default loki-mixin dashboards to TSDB #9772

trevorwhitney opened this issue Jun 22, 2023 · 9 comments
Labels
component/mixin good first issue These are great first issues. If you are looking for a place to start, start here!

Comments

@trevorwhitney
Copy link
Collaborator

trevorwhitney commented Jun 22, 2023

Given that TSDB is now the preferred index format for Loki, we should update the loki-mixin to reflect that. This probably includes:

  • making it easier to include TSDB dashboards / rows in the mixin via a configuration variable in the jsonnet
  • defaulting to TSDB when compiling the mixin
@trevorwhitney trevorwhitney added good first issue These are great first issues. If you are looking for a place to start, start here! component/mixin labels Jun 22, 2023
@pooladkhay
Copy link

Hi, I'd like to start working on this issue. Can I get a bit of help?

@trevorwhitney
Copy link
Collaborator Author

@pooladkhay sure thing!

So I think the best way to accomplish this is by adding a config section for setting the schema or enabling tsdb, like we have for our scalable deployment (aka ssd)

Then, in the relevant dashboard libsonnet, we can hide/show rows or panels, like here

It may require adding new rows to the raw dashboard json file, and then toggling their visibility in the libsonnet based on the config values set.

Once that is ready, you can change the defaults in mixin.libsonnet to set the appropriate configs, sort of like what we do in mixin-ssd.libsonnet.

Hope that helps!

@trevorwhitney
Copy link
Collaborator Author

@pooladkhay are you picking this up? Don't want to step on toes if you are, but we have some free cycles over here and were thinking if picking it up if you're not.

@pooladkhay
Copy link

@pooladkhay are you picking this up? Don't want to step on toes if you are, but we have some free cycles over here and were thinking if picking it up if you're not.

@trevorwhitney Please go ahead, I'm a bit busy unfortunately

@hainenber
Copy link
Contributor

hi @trevorwhitney, has you or your team picking up this yet? If not , I can volunteer to work on. Thanks!

@hainenber
Copy link
Contributor

Hi Trevor, it appears that currently there are no metrics to monitor TSDB shipper (see #9719), so my best effort for this task is to add placeholder settings

@Mahii25
Copy link

Mahii25 commented Nov 21, 2023

is this issue still open? I would love to work on it

@AravindAkuthota
Copy link

Hey @trevorwhitney i would like to contribute to the issue and work on it .please let me know anyone else working on it or not .

@trevorwhitney
Copy link
Collaborator Author

No, I don't think anyone is working on this at the moment. I'm not sure what the current state of the issue is either. #11087 added a tsdb boolean in the mixin config, which is used to govern the display of the structured metadata row. Are there other rows we need to put behind the same condition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mixin good first issue These are great first issues. If you are looking for a place to start, start here!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants