Make /ingester/shutdown endpoint work with GET
#11431
Labels
Comments
8 tasks
|
@andresperezl you beat me to this issue by less than a day! I was wondering why the kubernetes call wasnt working after flush on shutdown was removed from the ingester component :( |
8 tasks
MichelHollands
added a commit
that referenced
this issue
Dec 14, 2023
**Which issue(s) this PR fixes**: Fixes #11431 **Checklist** - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [X] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](0d4416a) --------- Signed-off-by: Michel Hollands <[email protected]>
rhnasc
pushed a commit
to inloco/loki
that referenced
this issue
Apr 12, 2024
**Which issue(s) this PR fixes**: Fixes grafana#11431 **Checklist** - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [X] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](grafana@0d4416a) --------- Signed-off-by: Michel Hollands <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently the
/ingester/shutdownendpoint only works with thePOSTmethod, but the kuberentes lifecyclehttpGet(as the name implies) sends aGETrequests, which doesn't do anything when triggered against that pod.Describe the solution you'd like
The
/ingester/shutdownendpoint should work with a HTTPGETrequestDescribe alternatives you've considered
The work around is using the
execto use a tool likewgetorcurlto send aPOSTrequest to the endpoint.Additional context
In the loki chart is using the
httpGetas well which is basically a no-op: https://github.com/grafana/loki/blob/main/production/helm/loki/templates/write/statefulset-write.yaml#L121https://grafana.com/docs/loki/latest/operations/storage/wal/#kubernetes-hacking
https://grafana.com/docs/loki/latest/reference/api/#flush-in-memory-chunks-and-shut-down
The text was updated successfully, but these errors were encountered: