From ec56013cc4b009a3849f6966b19f2226f74ec0f9 Mon Sep 17 00:00:00 2001 From: Owen Diehl Date: Mon, 7 Oct 2024 12:09:01 -0700 Subject: [PATCH] small updates Signed-off-by: Owen Diehl --- pkg/dash/dash.go | 3 +-- pkg/loki/modules.go | 5 ++++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/pkg/dash/dash.go b/pkg/dash/dash.go index ae28c5358b023..0131dde0b4caa 100644 --- a/pkg/dash/dash.go +++ b/pkg/dash/dash.go @@ -76,8 +76,7 @@ func ReadsDashboard(requestDuration *prom.HistogramVec) (dashboard.Dashboard, er "pod", ) - builder := dashboard.NewDashboardBuilder("Sample dashboard"). - Uid("generated-from-go"). + builder := dashboard.NewDashboardBuilder("Loki Reads (generated)"). Tags([]string{"generated", "from", "go"}). Refresh("1m"). Time("now-30m", "now"). diff --git a/pkg/loki/modules.go b/pkg/loki/modules.go index 5946cc7653aaa..536f6f87d8162 100644 --- a/pkg/loki/modules.go +++ b/pkg/loki/modules.go @@ -1782,7 +1782,10 @@ func (t *Loki) initDashboards() (services.Service, error) { return nil, err } t.Server.HTTP.Path("/grafana/dashboards/reads").Methods("GET").Handler(loader.Reads()) - return services.NewBasicService(nil, nil, nil), nil + return services.NewBasicService(nil, func(serviceContext context.Context) error { + <-serviceContext.Done() + return nil + }, nil), nil } func (t *Loki) deleteRequestsClient(clientType string, limits limiter.CombinedLimits) (deletion.DeleteRequestsClient, error) {